Close transactions after fines are voided,

[Steve Callender]

This was tested in 2.0 and 2.1.

When fines are voided and the balance of a transaction hits 0, the transaction really should have the xact_finish timestamped to keep things uniform on the system.

A prime example here is when an item is checked in with a backdate and the system auto-voids the fines. The xact_finish is never stamped and the transaction remains open forever.

Same thing with manually voiding fines, it does not close the transaction.

This doesn't really impact the staff client billings view since 0 balance items will not be shown, but it does impact reporting.

[Robert J Jackson (rjackson-deactivatedaccount)]

This bug also results in not being able to delete an account. A library attempting to delete an account ends up asking for assistance in order to have the transaction closed.

[Ben Shum (bshum)]

Just encountered the deletion issue Robert mentions. This seems more bug worthy, than wishlist to me.

Confirmed for 2.2+

[Steve Callender (stevecallender)]

Just another example of this happening is when a claims returned item is checked in using Amnesty to auto-void the fines, this causes the transaction to stay opened as well even though there is a stop_fines entry as well as 0 fines on the item. Same problem, just a different scenario. I imagine it's all still part of the same code though.

[Jason Stephenson (jstephenson)]

See also https://bugs.launchpad.net/evergreen/+bug/1009049 for issues with voiding in general.

[Jason Stephenson (jstephenson)]

In reviewing this bug description, there seems to be a discrepancy between the problem behavior reported in this bug and the solution to https://bugs.launchpad.net/evergreen/+bug/793550.

That bug is reporting a problem with claims returned closing transactions when the fine balance reaches zero. This bug is reporting the opposite issue.

I see that Steve Callender reports a specific scenario that can be tested in light of the patch to 793550. I'll leave this bug in its current state pending a review of that behavior in more recent code.

[Jason Stephenson (jstephenson)]

It looks like backdating an overdue copy, whether fines are owed or not, causes the transaction not to close.

[Jason Stephenson (jstephenson)]

The last commit on http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp965656_xact_close_logic fixes this for me. Other eyes more than welcome!

[Jason Stephenson (jstephenson)]

Force pushed a rebase today. I am also basing my work for this blueprint on the rebased branch:

https://blueprints.launchpad.net/evergreen/+spec/billing-enhancements

[Ben Shum (bshum)]

Picked to master, thanks Jason!