remove the library setting "Holds: Bypass hold capture during clear shelf process"

[Jason Etheridge]

it's not actually used anywhere nor will it be

[Daniel Rizea (danielrizea27)]

I added an upgrade sql script that removes the option from the library settings.

[Michael Peters (mrpeters)]

Daniel,

for future reference, a push to the evergreen-ils.org Git server is preferable to a patch file as it makes it easier for folks to test, signoff, and commit your submission.

Some great information on getting started with that is available at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git

As for commit messages, at a minimum, the commit message should consist of a subject line (i.e., the first line of the commit message), then a blank line, then an optional description of the patch, followed by one or more signoffs. The subject line should be brief, ideally no more than 60-70 characters, and should include a bug number from LaunchPad if relevant. Here is an example of a minimum commit message:

LP#24544: fix the quuxifier
Signed-off-by: Jane Hacker <email address hidden>

If you need any help getting started with submitting code this way in the future, please feel free to reach out to me (or any of the other devs) via email, or the Evergreen IRC chat. (#evergreen on Freenode.net).

Thank you, however, for your submission.

[Daniel Rizea (danielrizea27)]

I forgot to modify the seed sql file. This new patch modifies the seed file and also the sql update script handles foreign key constraint deletion in tables.

[Lebbeous Fogle-Weekley (lebbeous)]

Daniel's patches work. For the sake of closing an old bug, I treat this as if it had his sign-off (and it does have mine) THIS TIME.

In master.