Vandelay Inspect Queue doesn't load bib queues by default

[Thomas Berezansky]

Currently you need to change the queue type dropdown twice to get the queues to load (once away from bibs, then once to go back to them).

The branch below fixes this while changing the interface to reduce the number of clicks needed to load queues. In addition it adds batch queue deletion.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/vandelay_inspect_queue

[Michael Peters (mrpeters)]

Tested, and working as advertised. Thanks, Thomas!

user/mrpeters-isl/vandelay_inspect_queue_signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=fe79650a02b1facd2b2f54ef5968becb447e63c4

[Bill Erickson (berick)]

I'm getting an error when I select a queue to load (in master):

vlQueueGridLayout is null
https://dev198.esilibrary.com/js/ui/default/vandelay/vandelay.js
Line 995

Other changes have undoubtedly worked their way in since this branch was cut...

From the UI side, I'd like to see some padding between queue names in the list.

[Bob Wicksall (bwicksall)]

I applied this to my 2.2 RC 1 test server and it doesn't quite work. Deleting the queue works fine but clicking on a queue name results in the display of an empty queue.

This would solve a long standing complaint from our catalogers.

[Thomas Berezansky (tsbere)]

I have pushed a branch with a fix for the error to http://git.mvlcstaff.org/?p=tsbere/ILS.git;a=shortlog;h=refs/heads/vandelay_inspect_queue

I also added a second additional commit for the padding between queue names bit.

Both should cleanly cherry-pick onto Michael's signoff.

I would push to the working repo, but it is down right now (which means nobody is likely to be merging this right now...).

[Thomas Berezansky (tsbere)]

I have now rebased and force-pushed this due to the changes in master.

[Lebbeous Fogle-Weekley (lebbeous)]

Whenever I test the recent branch, upon logging in with the staff client I get these two messages in alert()-style dialogs.

"2: TypeError: offlineStrings.getString is not a function"

"1: TypeError: offlineStrings.getString is not a function"

and the staff client will not finish loading.

Is this happening to anyone else? The diff between this branch and master shows nothing that seems to me to account for this, so it could just be me, but it's happening to me despite make clean, and I'm not even sure where to start hunting this one down.

[Lebbeous Fogle-Weekley (lebbeous)]

I'm *still* having the same error, but after Thomas tried to reproduce it and couldn't, I'm 85% sure it's something wacky on my test system, so I hereby solicit anyone else to step up and test this.

Thanks!

[Lebbeous Fogle-Weekley (lebbeous)]

Thomas helped me track down the problem I was having. It was related to pre-2.2 cruft in my Apache config that caused a problem only when combined with staff client stamps beginning with 'vandelay'.

Anyway, Thomas's branch totally works and is going into master now.

Thanks all.