TPAC: Replace plus / minus signs with text + CSS

Bug #956658 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Won't Fix
Wishlist
Unassigned

Bug Description

While working on bug 956001 I noticed that the plus-sign and minus-sign images, used only for showing more or fewer copies, did not actually do anything when you clicked on them. In addition, they can be reasonably represented as plain text + CSS, saving an extra HTTP request per copy detail page that has more than 10 copies.

Moving the text + CSS into the <A> tag also makes them do something when you click them, which is kind of nice. And, being CSS, it's easy to change the colour scheme to suit a different site.

See branch user/dbs/text_css_plus_minus in working repository.

Tags: bitesize opac
Revision history for this message
Dan Scott (denials) wrote :

Removed pullrequest because this isn't quite there. Added another commit, though, to replace the circular rdetail_arrow*.png images in a similar fashion.

I'm finding getting the CSS just right for Chromium / Firefox / etc is annoying though, so maybe somebody else will want to pick this up and polish it off.

user/dbs/text_css_plus_minus in working repository

tags: removed: pullrequest
Changed in evergreen:
importance: Undecided → Wishlist
tags: added: bitesize
Changed in evergreen:
status: New → Incomplete
status: Incomplete → Triaged
Revision history for this message
Terran McCanna (tmccanna) wrote :

Still true as of 3.2.3.

tags: added: opac
Revision history for this message
Terran McCanna (tmccanna) wrote :

Marking Won't Fix due to development of the Bootstrap OPAC

Changed in evergreen:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.