TTPAC unused image cleanup

[Michael Peters]

There are a significant number of images remaining in TTPAC that are no longer used, leftover from KCLS, etc.

This branch does a little cleanup on the image directory and nets us about a 200KB savings overall.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=ab04528c40910e411c525aeec904fd3d46148911

[Bill Erickson (berick)]

Michael, did you also scan the CSS files for images in use? I quick grep shows a few of the removed images may be in use in /web/css/skin/default/opac/style.css as background images.

My quick list:

Open-ILS/web/css/skin/default/opac/style.css: background: url('/images/banner-bg.png') no-repeat;
Open-ILS/web/css/skin/default/opac/style.css: background: url('/images/button-bg.png') no-repeat;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/dropdown-hover.gif') no-repeat right center;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/dropdown.gif') no-repeat right center;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/facet_box_bg_bottom.png') no-repeat;
Open-ILS/web/css/skin/default/opac/style.css: background: url('/images/hp-links-mid.jpg') repeat-x;
Open-ILS/web/css/skin/default/opac/style.css: background:url('/images/utils-corner-left.png') no-repeat left top;
Open-ILS/web/css/skin/default/opac/semiauto.css:.left-corner { float: left; width: 163px; height: 30px; background: url('/images/utils-corner-mid.png') repeat-x top; }

I didn't check whether we are actually using the CSS classes in question, though. Can you confirm either way?

[Michael Peters (mrpeters)]

Bill -- from what I'd seen, these images aren't actually in use. They were the blue backgrounds from the KCLS skin. A while back we went through and took out lots of the backgrounds that were images and replaced them with CSS gradients.

I never saw these in use in the OPAC after we "Evergreen'd" it.

[Bill Erickson (berick)]

I thought that might be the case. Thanks M. I'm going to test/signoff and then push a follow-up patch to remove the unused CSS.

[Bill Erickson (berick)]

Sign-off and CSS cleanup pushed to

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/tpac-unused-image-cleanup

[Ben Shum (bshum)]

Looks good to me. When testing against current master, because of the recent conversion to template files for style.css, I ended up dropping the changes berick made in the style.css file. Looks like the master copy didn't have any of those images being used anyways. Haven't tested 2.2 branch, but assume that some tweaking may be needed to catch up with potential drift.

Sign-off for master: user/bshum/tpac-unused-image-cleanup

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/tpac-unused-image-cleanup

[Bill Erickson (berick)]

Merged to master / rel_2_3. Thanks, guys!