Create a "Standalone mode" staff client shortcut in the Windows installer

Reported by Dan Scott on 2012-03-14
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

This is a wishlist item.

Occasionally, network issues force the client to hang waiting on a response from a dead server and make it hard for staff to launch standalone mode, as the button on the full client won't respond.

Recent versions of Evergreen include additional command-line options for launching the staff client in standalone (offline) mode. However, many users are not comfortable with the command line.

Therefore, the desire is to teach the Windows installer to include a shortcut that launches the staff client into standalone mode.

Changed in evergreen:
assignee: nobody → Pranjal Prabhash (pranjal-prabhash)
status: New → Incomplete
status: Incomplete → In Progress
Dan Scott (denials) wrote :

Hi, we use "In Progress" to indicate that a committer is testing a proposed branch or patch, so I'm setting this back to the previous status until such time as the bug has been tagged "pullrequest" and a committer starts looking at it.

Changed in evergreen:
assignee: Pranjal Prabhash (pranjal-prabhash) → nobody
status: In Progress → New

In the file windowssetup.nsi, we have to add the following lines:

After line 106: CreateShortCut "$SMPROGRAMS\$ICONS_GROUP\Evergreen Staff Client (Standalone).lnk" "$INSTDIR\evergreen.exe" "-ILSoffline" "$INSTDIR\evergreen.ico"

After line 270: Delete "$SMPROGRAMS\$ICONS_GROUP\Evergreen Staff Client (Standalone).lnk"

Changed in evergreen:
assignee: nobody → Pranjal Prabhash (pranjal-prabhash)
status: New → In Progress

On Fri, Apr 6, 2012 at 12:40 PM, Pranjal Prabhash
<email address hidden> wrote:
> In the file windowssetup.nsi, we have to add the following lines:

Pranjal, you should give diff (and patch) a try. Ideally, you'd give
us a link to a git branch, but a patch file produced by diff is better
than asking us to hand-edit a file (though for one-off contributions
we probably wouldn't mind, so don't let that scare other would-be
contributors--I think we're just hoping for more from GSoC students).

-- Jason

Changed in evergreen:
status: In Progress → New
Jason Etheridge (phasefx) wrote :

Also, we still don't want the ticket to be In Progress yet. Once you're happy with the patch you're providing us, you should add a "pullrequest" tag to the ticket. Someone handling the request will change the status to In Progress.

Please find attached my patch for this bug.

New patch fixing a minor error. Tested on a windows 7 machine.

Michael Peters (mrpeters) wrote :

To make for easier testing by the devs, I've pushed a branch for you, this time Pranjal.

user/mrpeters-isl/standalone_mode_shortcut
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=06612422b979b6686542c1e7c2c520a7826b9fef

For future reference, a push to the evergreen-ils.org Git server is preferable to Github, patch files, etc., as it makes it easier for folks to test, signoff, and commit your submission.

Some great information on getting started with that is available at http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git

As for commit messages, at a minimum, the commit message should consist of a subject line (i.e., the first line of the commit message), then a blank line, then an optional description of the patch, followed by one or more signoffs. The subject line should be brief, ideally no more than 60-70 characters, and should include a bug number from LaunchPad if relevant. Here is an example of a minimum commit message:

LP#24544: fix the quuxifier
Signed-off-by: Jane Hacker <email address hidden>

If you need any help getting started with submitting code this way in the future, please feel free to reach out to me (or any of the other devs) via email, or the Evergreen IRC chat. (#evergreen on Freenode.net).

Thank you, again, for your work in solving this bug!

Hello Michael,

Sorry for this very late reply, I had my exams. I will surely keep that in mind, and Thank you for your help. I am working on another bug and will do as you said.

--Pranjal

tags: added: pullrequest
Changed in evergreen:
assignee: Pranjal Prabhash (pranjal-prabhash) → nobody
status: New → Incomplete
Changed in evergreen:
status: Incomplete → Triaged
Ben Shum (bshum) on 2013-03-17
Changed in evergreen:
milestone: none → 2.4.0-rc
Ben Shum (bshum) on 2013-04-22
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Ben Shum (bshum) wrote :

Picked to master for 2.5m1. Thanks Pranjal and Mike!

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum) on 2013-11-11
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers