TPAC: title tooltip in search results makes no sense

Bug #902979 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Bill Erickson

Bug Description

* Evergreen master

The tooltip displayed in search results when you hover over the title of a result makes no sense - it is the URI-encoded title itself, which the user can pretty plainly see on the page (and without spaces turning into %20 and the like).

Please see the branch named user/dbs/tpac_results_title_tooltip in the working repo for a simple fix that turns the tooltip into the more descriptive "Display record details".

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :

Force-pushed an update to accommodate layout changes from the non-fixed-width merge.

Revision history for this message
Bill Erickson (berick) wrote :

I believe the original intent was supposed to be [% attr.stitle | html %], i.e. display the actual title in the tooltip. From a usability perspective, I'm not really sure which is better. How about a blend of the two?

[% l('Display record details for [_1]', attrs.title) | html %]

If no one chimes in either way, I'll merge Dan's branch as-is. It's clearly better than what we have now.

Revision history for this message
Dan Scott (denials) wrote :

The original intent of displaying only the title in the tooltip -- even when it's not corrupted -- doesn't offer an advantage over simply not having any title attribute. Describing what will happen when you click the link does provide a reason to have a title attribute. Adding the title as you've suggested would be a nice enhancement.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: New → In Progress
Revision history for this message
Bill Erickson (berick) wrote :

Pushed modified version to collab/berick/lp902979_tpac_results_title_tooltip.

Note the use of HTML.attributes, as mentioned in the commit.

Revision history for this message
Dan Scott (denials) wrote :

Cool, thanks for demonstrating the use of the HTML.attributes - I'm sure that will come in handy in the future.

Committed to master. Thanks Bill!

Changed in evergreen:
status: In Progress → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.