Fixes for 2.1-2.2 upgrade script (alpha1)

[Dan Scott]

  * Evergreen 2.2-alpha1

Martha Driscoll tried out the 2.2-alpha1 upgrade script and found a few problems noted in this thread: http://list.georgialibraries.org/pipermail/open-ils-dev/2011-November/007747.html

#1. 2.1-2.2-alpha1.sql:3: ERROR: column "applied_to" of relation "upgrade_log" does not exist
> LINE 1: INSERT INTO config.upgrade_log (version, applied_to) VALUES .

This fails because the "applied_to" column does not yet exist.

#2. -- DROP objects that might have existed from a prior run of 0526

This will probably fail because most sites won't have applied 0526 to their production server, so the statements either should not be inside the transaction; or they should be run inside a function that checks to see if the objects to amend actually exist and need to be dropped.

Also, in my own testing I ran into:

#3. evergreen.is_json() function does not exist. This stems back to the public / evergreen function namespace issues we tried to address back in the 2.0(?) timeframe; my recommendation here is to _not_ qualify the function name and just let the searchpath handle it.

[Dan Scott (denials)]

Pushed a fix to user/dbs/lp896405_fix_2.2_upgrade-db in the working repo.

NOTE: this branch is based off of the tags/rel_2_2_alpha1 branch, because at the moment master does not have the upgrade script in it. See LP# 894052 for a branch that moves the upgrade script into master (in the version-upgrade directory); git should be smart enough to be able to apply this commit to that branch (it was when I tested it on Fedora 16, anyway!)

[Mike Rylander (mrylander)]

This is in master now, it seems. At least, cherry-pick says there's nothing to do. Closing.

[Dan Scott (denials)]

Yep, probably when you integrated the version-upgrade branch
(21adee5d2d4ad32cfd299edf72e3d70ec1428939) for LP# 894052. Thanks!