Default Shelving Location and Circ Modifier Do Not Work

Bug #867465 reported by Shae
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Bill Erickson

Bug Description

Originally reported by a customer at 2.0.7, I also tested this on a 2.1 rc system and found the same issue. When you enter the default shelving location and/or circ modifier in library settings, it does not stick. I added defaults to library settings, went to holdings maintenance for a title and added an item. I chose "create with defaults." It did not take the default shelving location and it didn't assign a circ modifier at all.

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :

Hi Shae: Quick check - did you log out of the staff client and log back in after changing the library settings?

Revision history for this message
Ben Shum (bshum) wrote :

Note, the default copy location/circ modifier applies only to new acquisitions I think. The labels aren't very descriptive of that, but phasefx pointed out to us that the underlying code had an acq. prefix to them.

For our libraries, we've been using the default copy location/circ modifier in library settings to generate initial values for acquisitions.

Revision history for this message
Ben Shum (bshum) wrote :

Just to follow up, the entries in config.org_unit_setting_type confirmed that they are acq related:

name, label

acq.default_circ_modifier, Default circulation modifier
acq.default_copy_location, Default copy location

To avoid future confusion, perhaps those labels should be updated with an "Acq: " prefix, or more detailed description be added to the description text, which are currently still blank.

Revision history for this message
Michael Peters (mrpeters) wrote :

Taking Ben's suggestion, here's a branch that updates the descriptions to prefix ACQ: to them.

user/mrpeters-isl/acq_default_description_improve

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=c733bb3aa26a5199ca95134d35f99132e7f7d0e7

tags: added: pullrequest
Changed in evergreen:
status: New → In Progress
importance: Undecided → Low
Changed in evergreen:
milestone: none → 2.2.0beta1
Changed in evergreen:
status: In Progress → New
Revision history for this message
Dan Scott (denials) wrote :

Hmm. I think that the problem might be that these are grouped under the rather generic "Library" group rather than, say, under an "Acquisitions" group.

See config.settings_group; if we added an ('acq', 'Acquisitions') row to that table, then set all of the org unit settings that are prefixed with "acq.*" to the "acq" group rather than "lib", I think we'd be in better shape than going back to the prefixing style of categorizing OUS that we used prior to OU setting groups.

A better description, as Ben suggested, would go a long way too... (See also acq.tmp_callnumber_prefix and others that are similarly obtuse).

Revision history for this message
Dan Scott (denials) wrote :

As a means of grouping all acquisitions-related OU settings under a new "Acquisitions" config settings group, I offer user/dbs/lp867465_csg_acq in the working repo.

Changed in evergreen:
milestone: 2.2.0beta1 → 2.2.0rc1
Changed in evergreen:
milestone: 2.2.0rc1 → 2.2.0
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: New → In Progress
Revision history for this message
Bill Erickson (berick) wrote :

Testified and mergified w/ master and rel_2_2.

Changed in evergreen:
status: In Progress → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.