Uploaded Purchase orders can't be activated

[Mary Llewellyn]

Evergreen version: 2.0.9
OpenSRF version: 2.0.0
PostgreSQL version: 8.4
Linux distribution: Ubuntu 10.04 Lucid

When you use the acq function "Load MARC Order Records", when you click on "Create Purchase Order" but not "Activate Purchase Order" and upload a vendor order straight to the PO, the purchase order cannot be activated, even after you've assigned a fund to the lineitems. The lineitems all have a status of "pending order" and can't be moved to "on order".

If you do click on "Activate Purchase Order" before uploading the vendor MARC order file, the same is true. The PO is not activated, and the lineitems have a status of "pending order."

[Kathy Lussier (klussier)]

I can confirm that this continues to be a problem as of 2.2 alpha 1, and I have a little more detail to add to this report. When you select "Create Purchase Order" but not "Activate Purchase Order," the state in acq.purchase_order is set to "on-order" when it should be set to "pending." If I change this value to "pending" through a direct database update, I am then able to activate the order.

When the "Activate Purchase Order" option is selected, the purchase order state is set to "on-order" as it should be, but the individual lineitems loaded into acq.lineitem with a state of "pending-order" when it should be a state of "on-order." If I do a direct update through the database to change the state of the lineitems to "on-order," then the PO appears to be activated.

[Bill Erickson (berick)]

I've pushed a fix for the first described problem:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp865552-acq-po-upload-state-repairs

[James Fournie (jfournie)]

We've tested this briefly on a test server running 2.0 and it looks good. I've signed off on it here on a master branch:

user/jamesrf/lp865552-acq-po-upload-state-repairs

[Bill Erickson (berick)]

Pushed signed-off branch to master. Thanks, James!

Regarding problem #2, if I recall correctly, Kathy said the problem did not exist in the Acq+Vandelay branch (which will hopefully be merged by 2.2). Did I understand you correctly, Kathy?

[Kathy Lussier (klussier)]

Yes, that's correct. I just retested it to verify. When I upload with the Acq+Vandelay branch and select Add to PO and Activate PO, the PO state is set to on-order, the state for the lineitems are set to on-order, and I see an activated date. It's all good!