Item Status Screen crashes on some barcodes

Reported by Thomas Berezansky on 2011-09-22
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
2.1
Low
Unassigned
2.2
Low
Unassigned

Bug Description

The crash originates from two different issues.

The first, somewhat indirect, issue is the Item Status screen's "Strict Barcode" implementation. Specifically, unlike all other points I could find, it does the strict barcode check *before* checking the status of the Strict Barcode checkbox.

The second, and direct, issue is that the "Strict Barcode" check does a "Is this a number?" check, as the algorithm can only handle pure digit sets, by saying "barcode == Number(barcode)". This returns true if barcode is, say, "987654321". It also returns true if barcode is, say, "16.00", which contains a non-digit(the "."), but is still a valid number. This causes the function to error out when it tries to do a regular expression match on a non-string.

I will attach a branch here shortly that solves both of those issues.

Mike Rylander (mrylander) wrote :

2 commits picked into master. Thanks!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
importance: Undecided → Low
Ben Shum (bshum) wrote :

Encountered this issue along similar lines with item barcodes that started with a dash. Request backport to 2.1 at least.

Changed in evergreen:
milestone: none → 2.2.0
Ben Shum (bshum) on 2011-11-28
Changed in evergreen:
status: Fix Committed → In Progress
assignee: nobody → Thomas Berezansky (tsbere)
Changed in evergreen:
assignee: Thomas Berezansky (tsbere) → nobody
Dan Scott (denials) wrote :

Checked to see where this lives and it has been committed to master, at least.

Changed in evergreen:
status: In Progress → Fix Committed
Jason Stephenson (jstephenson) wrote :

So, are we waiting on someone to backport this to 2.1?

Changed in evergreen:
status: Fix Committed → Fix Released
milestone: 2.2.0alpha1 → none
Dan Scott (denials) wrote :

Cherry-picked both commits to rel_2_1. Thanks Thomas!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers