Cannot replace barcode if patron does not have card

[Jeff Davis]

On our Evergreen 2.0.8 system, it sometimes arises that a patron's card gets deleted. If it was the patron's only card, it becomes impossible to add a new card to the account via the staff client.

How to reproduce:
1. Retrieve a patron record for a patron who has no associated card.
2. Click the Edit button.
3. Click Replace Barcode and enter a new barcode.
4. Click Save. This does not work - the process hangs, and if you hit Reload, you will find that your changes were not saved.

I believe this happens because some code in register.js assumes the patron has at least one card. I have a potential fix that this comment box is too small to contain ... uh, that is to say, I will post it momentarily.

[Jeff Davis (jdavis-sitka)]

A proposed fix:

https://git.sitka.bclibraries.ca/gitweb/?p=sitka/evergreen.git;a=commitdiff;h=refs/heads/user/jeffdavis/trunk-lp851110-replace-barcode

[Jeff Davis (jdavis-sitka)]

And here it is in patch form.

[Thomas Berezansky (tsbere)]

Any chance you can force-push the commit with a sign-off?

[Mike Rylander (mrylander)]

In the interest of getting the code in, I've applied the patch to master and backported through 2.0. Thanks, Jeff!