Adding Equinox Sample Reports to Master

[Jason Stephenson]

It was recently suggested in IRC that someone have a look at merging the Equinox sample reports for 1.6 into master. Currently, these reports are most easily available at

svn://svn.open-ils.org/ILS-Contrib/ESI-Examples/reports

For the most part, the reports will load and run correctly. However, a handful of reports exhibit some odd grouping behavior and will likely need to be recreated.

The Count Items Added by Date Range and Statistical Category report appears to group all entries in the same stat_cat when counting and does not properly group by stat_cat entry values. Some investigation, this is the case because the report was not created with nullability selection turned on, so the resulting join clauses include null values when counting. The fix for this is to recreate the report with nullability selection enabled and to never count nulls.

The Count Patrons by Library & Statistical Category report has the same problem as the above.

The two reports to list patrons with outstanding balances both return sums of 0.0 or 0.00 for each patron. They also suffer from not having nullability selection enabled and so appear to be summing in null values with regular values, thus getting 0 in the end. The solution for these two reports also appears to be to recreate them with nullability selection and to not count null values when summing, etc.

Finally, the List Available Holds by Capture (Clean Holds) report under the Library Services reports gets the holds by the requester. It is possible that the requestor is not always the user as that is an optional setting. Either this report should be changed to get the holds available by user or a new report should be created for that purpose. In the latter case, the report names should reflect whether or not they are displaying the requester or user field.

[Michael Peters (mrpeters)]

I took a stab at including the ESI report templates in the initial db build for clean installs. http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=9c54468e148aaf6d73589cfd1b4e1051ad71b0d4

I changed the title of "List Available Holds by Capture (Clean Holds Shelf)" to reflect the way it handles the requesting user. I also commented out the addition of the two reports needing nullability, but left them in the SQL in case someone can fix those as well.

This was my first try at adding something to the database install process, so please let me know if I've missed something.