Reporter shows "Action Succeeded" when in reality, it didn't

[Michael Peters]

Evergreen 2.0.4
OpenSRF 2.0.0
PostgreSQL 8.4
Debian Squeeze

When attempting to delete a report template, owned by "User A" which is referred to by reports created by "User B" the staff client reports that the action succeeded when in reality, it does not, due to still being used by other users.

We shouldn't be sending a misleading message so there needs to be some kind of indication to the user that the deletion was unsuccessful.

[Jason Stephenson (jstephenson)]

Needs confirmation in 2.1+.

[Jason Boyer (jasonb-myjclibrary)]

I can confirm that I've seen this still on 2.2.2. I've tried to delete templates other users have built reports against and received a false success message, and also when trying to move a report from one folder to another that would cause a duplicate name conflict.

[Remington Steed (rjs7)]

This behavior still exists in 2.5. Also, if you own any reports attached to the template you are trying to delete, those are successfully deleted. The code looks like it throws an error when it finds a report owned by a different user, but that apparently isn't working. Here's where I'm looking:

web/reports/oils_rpt_folder_window.js: 420
oilsRptFolderWindow.prototype.deleteTemplates = function(...
...
    if( tmpl.owner().id() != USER.id() ) {
        this.deleteTemplates(list, ++idx,
            callback, 'oils_rpt_folder_contents_no_delete');

[Remington Steed (rjs7)]

It looks like the javascript was just missing a check for the case of partial failure. This branch should take care of it.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/reporter_wrongly_shows_success

working/user/rsteed/reporter_wrongly_shows_success

[Dan Wells (dbw2)]

Works for me. Pushed to master and backported through rel_2_4. Thanks, Remington!