Support PO activation without requiring bibs/items

[Bill Erickson]

Currently, it's not possible in Evergreen to activate a purchase order without loading/linking the bibs and copies into the "main" database (i.e. biblio.record_entry, asset.call_number, asset.copy). This patch creates a new "Activate PO Without Loading Items" option in the PO display and activates the PO without, well, loading items and copies.

I've tested this patch through a full order cycle, including invoicing, printing worksheets, printing invoice vouchers, etc. I have not had any trouble with it, but other eyes/testers would be appreciated, since activated PO's are generally assumed to have copies attached.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/acq-po-activation-sans-assets

Evergreen 2.2 / OpenSRF 2.0 / Postgres 9.0.4 / Debian Squeeze

[Mike Rylander (mrylander)]

Picked into master for great justice!

[Bill Erickson (berick)]

Re-opening ticket since only 1 of the 2 commits in the feature branch were merged. The second, merged commit is effectively irrelevant without the first commit.

The un-merged commit conflicts heavily with current master. Will push an updated feature branch after conflict resolution.

[Bill Erickson (berick)]

Pushed an updated branch to working => user/berick/acq-po-activation-sans-assets-round2

Commit which needs to be merged is:

commit 08ac64caf47de7d5e6ff5d0a7f8c8a0a53f81cb2
Author: Bill Erickson <email address hidden>
Date: Tue Nov 27 15:26:48 2012 -0500

    Support PO activation w/o loading items
    ....

[Jason Stephenson (jstephenson)]

Sounds like someone, other than Bill, who can test acquistions should test the updated branch.

[Kathy Lussier (klussier)]

Hi Bill,

Looks like this one has been gathering dust. We're getting a conflict with your round 2 branch. Can you rebase it?

[Bill Erickson (berick)]

Hah, gathering dust indeed.. going on 2 years. Rebased code pushed to

working/user/berick/acq-po-activation-sans-assets-round3

I've also removed the (old) 2.2, 2.3, and 2.4 targets from this LP entry since this is more of a feature than a bug fix.

[Kathy Lussier (klussier)]

Works for me! I added a release notes entry and signed off on it at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/acq-po-activation-sans-assets-round3.

Kathy

[Dan Wells (dbw2)]

Hello Bill,

I am interested in pushing this, but I have one concern first. It seems like this change:

@@ -2659,7 +2664,7 @@ sub activate_purchase_order_impl {
         $li->state('on-order');
         $li->claim_policy($provider->default_claim_policy)
             if $provider->default_claim_policy and !$li->claim_policy;
- create_lineitem_debits($mgr, $li, $dry_run, $options) or return $e->die_event;
+ create_lineitem_debits($mgr, $li, $dry_run) or return $e->die_event;
         update_lineitem($mgr, $li) or return $e->die_event;
         $mgr->post_process( sub { create_lineitem_status_events($mgr, $li->id, 'aur.ordered'); });
         $mgr->respond;

effectively prevents the 'zero-copy-activate' option from reaching create_lineitem_debits, but that sub still looks for the option. Is this a mistake, or dead code, or something else I am not understanding?

Thanks,
Dan

[Bill Erickson (berick)]

Good eyes, Dan! It was a mistake -- a partial attempt at consolidating $dry_run and $options. I've pushed a rebased branch with a fix for that issue and a sign-off for Kathy's release notes (Thanks, Kathy!) to:

working/user/berick/acq-po-activation-sans-assets-round4

[Dan Wells (dbw2)]

Fix looks good to me, thanks Bill and Kathy.

Pushed to master... finally! :)