Bill History - Payments tab, lacks ability to track workstation where payment was accepted

[Michael Peters]

This "bug" is actually an enhancement request. I believe the bill_history.xul (Patron > Bills > History > Payments) interface could benefit from the addition of a link back to the user/workstation/ou that accepted the payment.

Currently, each payment must have the "Full Details" interface opened to track down the acceptor of the payment. This makes auditing a bit tedious.

A "picker" option here would allow staff to quickly see all instances of the acceptor in the billing history list, rather than tracking each one individually in full details.

phasefx was kind enough to share some hints on how we could create something similar to BLOB_MBTS_DETAILS_RETRIEVE to pull in detailed information on all of the payments but I'm feeling a bit overwhelmed by this.

2011-07-14T15:58:48 <phasefx> make a method like open-ils.actor.user.payments.retrieve, maybe call it open-ils.actor.user.payments.details.retrieve, and have it return other stuff in addition to mp
2011-07-14T15:59:10 <phasefx> then use that method instead
2011-07-14T16:05:36 <phasefx> mrpeters-isl: in this case, in Actor.pm, I'd copy/paste the code for open-ils.actor.user.payments.retrieve, and tweak it

[Michael Peters (mrpeters)]

I've pushed user/mrpeters-isl/actor_user_payment_details which handles the Perl side of this, by creating a new API, as phasefx suggested, to pull in information regarding the workstation and user that accepted payment for any particular transaction.

As the commit message suggests, this only creates the API as I'm still struggling a bit with the bill_history.js to link this up.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=4d63b46fc8378763d4636241b9735d1ffc418fcf

[Jason Etheridge (phasefx)]

Michael, if I'm understanding things correctly, this can't be used as a drop-in replacement, because mdp = money desk payment, which is a subset of all payments, so we're missing out on things like forgive payments. Also, the order clause in the json query is still mp. I think we can wait until we have a complete end to end solution before doing any merging.

[Josh Stompro (u-launchpad-stompro-org)]

See bug #1354482 for discussion on adding workstation to all payment types to be able to track where all staff received payments are accepted.
https://bugs.launchpad.net/evergreen/+bug/1354482

[Terran McCanna (tmccanna)]

+1 to adding the Cash Drawer location to the Payments history tab (in the web staff client).