calculate patron penalties after marking item damaged (Change Amount)

Reported by Jason Etheridge on 2011-07-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Related to bug #812355, but this when the Bill Patron Wizard is invoked from the Mark Damaged -> Change Amount workflow. Penalties need to be generated.

In Circ/Money.pm, line 703, we have
my $evt = OpenILS::Utils::Penalty->calculate_penalties($e, $xact->usr, $U->xact_org($xact->id));

If I move this so that it happens after the $e->commit; it seems to work, but I don't know why. The method is supposed to work with an existing editor within a transaction.

Jason Etheridge (phasefx) wrote :

This is actually fixed with the patch in bug #812355, which was in place when I tested that line 703 change. The Bill Patron Wizard doesn't actually create a billing in this workflow, and passes the values to mark_item_damaged as override params to handle.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers