receipt template editor uses non-existent macro %id% for default templates

Bug #811175 reported by Steven Chan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

Evergreen 2.0.5
OpenSRF 1
PostgreSQL 8.4

The receipt template editor is referencing the macro %id% rather than %mbts_id% in default bills templates. The test data generating previews happen to work but when printing to a file or printer, bill numbers are shown as 'Bill #%id%'.

Tags: pullrequest
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jeff Godin (jgodin) wrote :

The branch working/jeff/lp811175_billing_receipt_macros should correct this issue. I'd recommend backporting to rel_2_1 and rel_2_0

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/lp811175_billing_receipt_macros

Revision history for this message
Jeff Godin (jgodin) wrote :

The branch only fixes the default set of templates.

To see the fix on an existing client, you will need to either delete the print_list_templates file (to reset all templates) or manually adjust templates.

Anyone care to object to an alias macro for the billing receipt templates so that existing templates using %id% do not require adjustment? I'll look at that in the meantime.

Revision history for this message
Jason Etheridge (phasefx) wrote :

This branch signs-off on Jeff's patch and introduces 2 more. One for more mbts macros, and another for silently replacing such macros in old templates.

collab/phasefx/merged_bill_and_receipt_fixes @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/merged_bill_and_receipt_fixes

tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Merged Jason's branch into master. 2.1 had a big pile of conflicts.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.