I think the git and the patch should be exactly the same; I wonder if it is
due to attempting to use the largest int as the number of items per page?
Maybe there is some kind of sign change (does Javascript have signed and
unsigned?)

--
Public Key: [0xF8462E1593141C16]<http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xF8462E1593141C16>

For a successful technology, reality must take precedence over public
relations, for nature cannot be fooled.
  - Richard Feynman



On Wed, Jun 22, 2011 at 3:00 PM, Jason Stephenson <<email address hidden>
> wrote:

> Got the following in JavaScript console while running with the attached
> patch on a system based on master with 271 config.circ_matrix_matchpoint
> entries:
>
> Error: uncaught exception:
> {"hash":{"threadTrace":0,"type":"REQUEST","payload":{"hash":{"method
> ":"open-
>
> ils.pcrud.search.ccmm","params":["be26267bc61cc35cd018d4b4e3459537",{"id":{"!=":null}},{"order_by":{"ccmm":"circ_modifier"},"limit":9000000000000000}]},"_encodehash":true,"method":null,"params":null,"serialize":null},"locale
> ":"en-
>
> US"},"_encodehash":true,"threadTrace":null,"type":null,"payload":null,"locale":null,"serialize":null}
>
> and the policy editor never populates, of course.
>
> pen-ils.pcrud 2011-06-22 16:45:34
> [INFO:5423:osrf_application.c:1040:130877528654856] CALL: open-ils.pcrud
> open-ils.pcrud.search.ccmm
> "be26267bc61cc35cd018d4b4e3459537",{"id":{"!=":null}},{"order_by":{"ccmm":"circ_modifier"},"limit":9000000000000000}
> open-ils.pcrud 2011-06-22 16:45:34 [ERR
> :5423:oils_sql.c:5512:130877528654856] open-ils.pcrud: Error retrieving
> config::circ_matrix_matchpoint with query [SELECT  "ccmm".id,
> "ccmm".is_renewal, "ccmm".active, "ccmm".org_unit, "ccmm".copy_circ_lib,
> "ccmm".copy_owning_lib, "ccmm".user_home_ou, "ccmm".grp,
> "ccmm".circ_modifier, "ccmm".marc_type, "ccmm".marc_form,
> "ccmm".marc_bib_level, "ccmm".marc_vr_format, "ccmm".ref_flag,
> "ccmm".juvenile_flag, "ccmm".usr_age_lower_bound,
> "ccmm".usr_age_upper_bound, "ccmm".item_age, "ccmm".circulate,
> "ccmm".duration_rule, "ccmm".recurring_fine_rule, "ccmm".max_fine_rule,
> "ccmm".hard_due_date, "ccmm".renewals, "ccmm".grace_period,
> "ccmm".script_test, "ccmm".total_copy_hold_ratio,
> "ccmm".available_copy_hold_ratio FROM config.circ_matrix_matchpoint AS
> "ccmm" WHERE "ccmm".id IS NOT NULL ORDER BY circ_modifier LIMIT
> -889552896;]: 0 ERROR:  LIMIT must not be negative
>
> Got the above in osrfsys.log.
>
> It looks like the limit is going negative on my system. However, I don't
> see where in your patch the limit is being set. Rather bizarre.
>
> On an unpatched system, running code that is otherwise identical to my
> dev server, I don't get the above error.
>
> I applied the patch rather than merge your git branch because I'm trying
> to keep my dev environment as close to what we're running in production
> as possible at the moment. I might merge the branch and give that a try
> later to see if the behavior continues.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/800846
>
> Title:
>  Circulation Policy Editor is not very easy to use.
>
> Status in Evergreen - Open ILS:
>  New
>
> Bug description:
>  Problem:
>  Occasionally the grid is "clipped", scrollbars display strangely, the back
> and forward buttons display even when there are no more pages, there is no
> easy way to search/filter, and there is javascript in the HTML file.
>
>  Versions:
>  It looks like most versions are affected up to and including the current
> main branch in the git repo.
>
>  About the patch:
>  The included patch should be able to be backported and possibly fix bugs:
>  * 517699 Display clipped in the Circulation Policy Configuration editor
>  * 747402 Circulation Policy Configuration function broken
>  plus some of the concerns raised in 747402.
>
>  The patch has been tested on test system with sixteen records.
>
>  The git repo that the patch was taken from is at:
>  git://git.evergreen-ils.org/evergreen/joelewis.git
>  the branch is "circ_config_policy".
>
>  Thanks,
>      Joseph
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/800846/+subscriptions
>