some org unit settings don't have i18n support

[Joseph]

In Evergreen's trunk, the config.org_unit_setting_type(s):

 * circ.holds.behind_desk_pickup_supported
 * circ.holds.canceled.display_age
 * circ.holds.canceled.display_count
 * cat.marc_control_number_identifier
 * circ.holds.max_org_unit_target_loops
 * circ.holds.org_unit_target_weight
 * circ.user_merge.delete_addresses
 * circ.user_merge.delete_cards
 * circ.user_merge.deactivate_cards
 * circ.holds.uncancel.reset_request_time
 * circ.holds.target_holds_by_org_unit_weight

All don't use the oils_i18n_gettext() for labels or descriptions, it looks like when database patches got applied they somehow got missed.

[swenyu duan (dsy88)]

I modified the corresponding upgrade sql and tested it on debian. should i post it to the dev mail list?

[Jason Stephenson (jstephenson)]

Swenyu,

No need to send an email to the dev list. All of the relevant people are emailed when a bug is updated, so they've seen that your patch has been submitted.

Thanks for the submission!

Jason

[Dan Scott (denials)]

Hi Swenyu:

One note - your "author" field in the patch shows as "root <email address hidden>". If you use the "git config user.name" and "git config user.email" commands per http://www.open-ils.org/dokuwiki/doku.php?id=dev:git, when you commit code and generate patches it will show your real user name and email address.

If you set those git configuration variables, then use "git commit --amend --reset-author", you'll be able to generate an updated patch accordingly.

Thanks very much for your patch!

[swenyu duan (dsy88)]

Hi Jason and Dan:

Thank you for your answers.I'm sorry for that. And I reset author part and upload it again. Look forward your check!

swenyu

[Thomas Berezansky (tsbere)]

Fixing the status - Fix Committed hides from most of our lists and should only be applied when the changes have, in fact, been committed to the core repositories.

[swenyu duan (dsy88)]

sorry for that, i misunderstand the status meaning.

[Jason Stephenson (jstephenson)]

If I understand things correctly, this bug is ready for testing and integration, so I've added the pullrequest tag.

[Pasi Kallinen (paxed)]

Applying the patch to master fails.

[Galen Charlton (gmc)]

The patch can be made to apply by passing --ignore-whitespace to git-am.

However, there's no point in applying it -- the oils_i18n_gettext markers only matter in 950.data.seed-values.sql; build/i18n/Makefile does not specify extracting strings from any other SQL script. As far as the upgrade scripts are concerned, oils_i18n_gettext() is purely a no-op.