Patron Search - ID's in column display

[George Duimovich]

Evergreen: 2.0.6 / Staff Client 2.0.6
OpenSRF: 1.6.3
PostgreSQL: 8.4
Linux: Ubuntu 10.04 (Lucid)
------------------------------------------------
Minor issue.

In Patron Search, a couple of key fields (column display) show id's instead of data-text.

See attached image

[George Duimovich (george-duimovich)]

image attached

[Michael Peters (mrpeters)]

Columns Affected:

Primary Identification Type
Secondary Identification Type
Main (Profile) Permission Group

I'm taking a look at this to see if I can make sense of it. Maybe we can "link" these in a similar way that the "Home Library" column is linked to use the actor.org_unit.shortname instead of actor.usr.id.

[Michael Peters (mrpeters)]

George,

This patch adds some new columns to the picker, and hides the broken ones.

You'll want to use:

Permission Group: Group Name
Ident Type: Identification Name
Ident Type 2: Identification Name

This is working on my dev server with 2.0.4 but should work with other 2.x versions. Thanks to phasefx for leading me through this!

[Jason Etheridge (phasefx)]

Not intending to counter Mike's good work (which uses the existing infrastructure, and is less risky), but I tweaked the list infrastructure itself to provide another way of doing this. It's in a working/Evergreen.git branch, collab/phasefx/fm_columns

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=97df31101f5a1164c65d049241fee51a16ad7a39
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=b88f3f1cc252e0add3813c2b3e190be685fb2b77

[Jason Etheridge (phasefx)]

Think we should apply Mike's patch to 2.0/2.1 and my branch to master?

[Jason Etheridge (phasefx)]

Committed Mike's patch to rel_2_1 and rel_2_0:
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e6c4793e80e770002a59e9bea43607bc16b3b6dc
http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=204d30c967f02df8a3054ea852b320f692407d88

[Mike Rylander (mrylander)]

So, are we just waiting on a merge to master? If that's now obviated,
let's kill the bug. If not, point me at a branch! :)

[Dan Scott (denials)]

Sorry, I'm going to test phasefx's branch for master and commit if it's good. Real soon now.

[Dan Scott (denials)]

Testing Jason's branch for master:

Good columns:
  * Main (Profile) Permission Group:
  * Primary Identification Type:
  * Secondary Identification Type:

However, I noticed that "Internet Access Level" still shows an integer value; should display the "name" attribute for that too. I'm going to merge the branch as is, but keep the ticket open for this little buggie.

[Dan Scott (denials)]

Committed Jason's fixes with a change to the formatting of the commit message to use multiple lines and to keep lines less than 80 columns long...

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ca161469259582e86544dcb4c176b9d8dca47a3c

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bbf03b1937f4a60758f0538f145a1a08921eda78

[Dan Scott (denials)]

Pushed a fix for "Internet Access Level" as well: http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b360117be6c1efc24da34612a080a2d942134206

Marking as "Fix Committed".