squashing of params in circ/util.js

[Jason Stephenson]

In the function checkin_via_barcode2 in circ/utils.js, the function argument named params gets squashed if we print a hold_slip or hold_transit_slip. The code block to print the slip redefines params with a "var params" statement.

The attached patch renames the second params variable to be named parms.

The bug manifests itself in the client when the slip is printed. The no_change_label says "undefined is in transit" rather than "[barcode] is in transit."

The code is also available at git://<email address hidden>/jason/ILS in the params2parms branch.

[Jason Etheridge (phasefx)]

trunk: http://svn.open-ils.org/trac/ILS/changeset/20368
rel_2_1: http://svn.open-ils.org/trac/ILS/changeset/20369
rel_2_0: http://svn.open-ils.org/trac/ILS/changeset/20370

Thanks!