Repeating receipt template macros, case sensitivity in macros
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Galen Charlton |
Bug Description
Evergreen Versions effected: (at least) 1.6.0.0->trunk. Patch against 2.0.4
There was discussion in bug 744492 about making receipt template macros case-insensitive. This patch does that, and also adds g to most options making it possible to use the same macro more than once in a template section. PATRON_BARCODE and patron_barcode haven't been touched because it sounds like there are other plans for them.
An example for the second: I'm trying to use the shortcode in a switch statement to determine which library-specific contact information to print on a receipt, and we also print the shortcode itself in the same section (the footer in this case). Without the g option, whichever use comes first in the section is the only substitution made, with %SHORTCODE% printing anywhere else it's used in that section.
Notes about the patch: I'm hoping that it doesn't need to be run through dos2unix; it took a convoluted road to get from where it was to where I am, but I believe it's ok.
Changed in evergreen: | |
assignee: | nobody → Galen Charlton (gmc) |
Changed in evergreen: | |
importance: | Undecided → Wishlist |
importance: | Wishlist → Low |
Changed in evergreen: | |
milestone: | none → 2.2.0 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Any opinions on this? I'm assuming there's not a good reason to keep case sensitivity, and the g option is an oversight that has been corrected in most of the new date macros.