Fine Generator Ignores lack of fines
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In the event of a 0 fine rate, 0 fine interval, or 0 max fines the fine generator will still put in the effort to generate fines. This may be problematic, or at least cause lots of useless churn on some data.
In the case of the 0 fine interval it is likely to throw faults due to unchecked division by 0.
Attached is a quick patch to have the fine generator bail early on a circ that meets any of those three criteria, particularly before the fine interval is used in a division context.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Thomas Berezansky <email address hidden>
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Patch committed to trunk, rel_2_1, and rel_2_0. tsbere++