Patron Registration Surveys/Stat Cats

[Thomas Berezansky]

Patron registration in "Suggested" mode doesn't show surveys/stat cats as intended. Mainly because I wasn't paying enough attention at some point when committing it locally, I think.

Also noticed, though, that "required" surveys don't show up as required. Split that into a second commit/patch.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Thomas Berezansky <email address hidden>

[Thomas Berezansky (tsbere)]

For those who want to use git to pull my git branch:

To add my remote using id "tsbere" (only needs to be done once):

git remote add tsbere git://git.mvlcstaff.org/tsbere/ILS

If you don't use tsbere as the identifier here all of the below commands referring to tsbere will need to be adjusted.

Don't forget to fetch/update the remote:

git fetch tsbere
OR
git fetch --all

This branch will be tsbere/patronreg_fixes

To check out the branch:

git checkout -b tsbere_patronreg_fixes tsbere/patronreg_fixes

To merge into your current branch (change branches first!):

git merge tsbere/patronreg_fixes

To merge changes you made to your checked out version into the current branch (change branches first!):

git merge tsbere_patronreg_fixes

[Mike Rylander (mrylander)]

Commited to trunk and rel_2_1. Does this need to go back to 2.0?

[Thomas Berezansky (tsbere)]

I don't think my registration enhancements ever hit 2.0, so the patronreg_suggested one isn't needed there.

As it stands, though, my testing indicated that anywhere with the new registration screen and a required survey won't be able to register a patron in "Show Required Fields" mode because the required survey won't show up. That is what the patronreg_surveyrequired.patch does, and I believe it would potentially apply to 2.0.