Paying Bills with Patron Credit does not always decrease patron Credit in 2.0.2

[Aaron Z]

I created a patron (barcode Test1234) on the acq.open-ils.org server from a 2.0.2 client installed on my Win7 x64 system. I created two bills (# 6 and 7) for $30 each. I created a cash payment of $40 with just bill #6 selected and checked the box marked "Convert Change to Patron Credit" (Payment #6) .
This cleared bill #6 and left me the patron with $10 in credit and $30 owed in fines.
I next made a patron credit payment of $5 (Payment #7). That paid down the patrons fine bill by $5, but did NOT reduce the patron credit amount at all.
I closed all of the tabs and re-retrived the patron and they still have a Patron Credit of $10 and still owe $25

Aaron Z

[Jason Etheridge (phasefx)]

See this older trac entry, http://svn.open-ils.org/trac/ILS/ticket/28, for a possibly related bug.

[Dan Wells (dbw2)]

I think the attached patch addresses this properly, as we need to deduct from the credit whether we actually pay off the bill or not. This problem looks like it was introduced here, which was a fairly extensive restructuring: http://svn.open-ils.org/trac/ILS/changeset/14628/trunk/Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm

Barring any negative feedback, I will commit and backport.

Thanks,
Dan