Paying Bills with Patron Credit does not always decrease patron Credit in 2.0.2

Bug #724583 reported by Aaron Z
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Dan Wells

Bug Description

I created a patron (barcode Test1234) on the acq.open-ils.org server from a 2.0.2 client installed on my Win7 x64 system. I created two bills (# 6 and 7) for $30 each. I created a cash payment of $40 with just bill #6 selected and checked the box marked "Convert Change to Patron Credit" (Payment #6) .
This cleared bill #6 and left me the patron with $10 in credit and $30 owed in fines.
I next made a patron credit payment of $5 (Payment #7). That paid down the patrons fine bill by $5, but did NOT reduce the patron credit amount at all.
I closed all of the tabs and re-retrived the patron and they still have a Patron Credit of $10 and still owe $25

Aaron Z

Revision history for this message
Jason Etheridge (phasefx) wrote :

See this older trac entry, http://svn.open-ils.org/trac/ILS/ticket/28, for a possibly related bug.

Revision history for this message
Dan Wells (dbw2) wrote :

I think the attached patch addresses this properly, as we need to deduct from the credit whether we actually pay off the bill or not. This problem looks like it was introduced here, which was a fairly extensive restructuring: http://svn.open-ils.org/trac/ILS/changeset/14628/trunk/Open-ILS/src/perlmods/OpenILS/Application/Circ/Money.pm

Barring any negative feedback, I will commit and backport.

Thanks,
Dan

Changed in evergreen:
milestone: none → 2.0.3
assignee: nobody → Dan Wells (dbw2)
Dan Wells (dbw2)
Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.