Missing examples for "interval" settings in Library Settings Editor

[Michael Peters]

A few cases were found in the Library Settings Editor where "interval" datatype's are used, but there is no layman's cue as to what the expected format should be. I've updated these to include a visual cue as to the expected formats.

For example:
- 'Holds: Hard stalling interval',
+ 'Holds: Hard stalling interval -- Example "5 days", "1 hour", etc.',

I found multiple ways of giving this cue throughout the database, so perhaps some standardization would be good in the future. To avoid changing anything that wasn't missing a cue, I left those alone. This patch affects only the interval values that were missing this information.

This patch is valid against Evergreen Trunk, but should apply to other versions 1.6 and up, at least.

[Michael Peters (mrpeters)]

Patch updated to play nice with tsbere's 950.data-seed-values.patch

[Michael Peters (mrpeters)]

Oops - TortiseSVN gave Windows/DOS EOL format. Sorry - fixed here

[Dan Scott (denials)]

Thanks for the patch, Michael. I have applied a version of it to trunk in r19558. Key differences being, rather than:

foo -- Examples "5 days", "1 hour", etc.

I went with something like:

foo. Examples: "3 weeks", "7 days"

Rather than leaving the previous phrase dangling and appending an emdash, which normally appears in the middle of a sentence, I ended the previous phrase with a period and introduced the examples with a colon delimiting the "Examples" label and the examples themselves. I also left out the "etc." as that is frowned upon when providing material for translators, and it is arguably implicit in that these are labelled as examples; nobody would expect them to be the complete set :)

I also changed the units of time in the examples to try to provide something in the ballpark of the context of the description; for example, the default estimated wait for a hold is extremely unlikely to be "1 hour".

I also created the upgrade script and modification to the 002.schema.config.sql file that is required for database schema patches. This isn't absolutely necessary for patches but is nice to be aware of for the future.

Finally - thanks very much for your patch and for improving Evergreen!

[Dan Scott (denials)]

Also applied to rel_2_1. While this is a nice usability enhancement, I'm not sure we should be backport it to a stable release.