STAFF_CHR override gives generic skull and crossbone error when aborting override,

Bug #647121 reported by Steve Callender
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Declined for 2.2 by Jason Stephenson
Declined for Main by Jason Stephenson
2.0
Fix Released
Undecided
Unassigned
2.1
Fix Released
Undecided
Unassigned

Bug Description

Tested in 2.0. When checking out an item to a patron that hit the STAFF_CHR penalty, you are prompted with an override box. When clicking cancel on the override, the generic skull and crossbones error is thrown on the screen.

I believe the override is just not being handled correctly or not completely finished. The error appears to be cosmetic only and not really affecting anything, so this is not a huge priority but it is something that should be looked into.

Tags: pullrequest
Revision history for this message
Michael Peters (mrpeters) wrote :

Tested on 2.0.4 and error seems to be handled.

Gave a test user the "STAFF_CHR" standing penalty and attempted a checkout. Result was the normal "override" popup but no skull/crossbones. Judging from the date of this bug, I'm thinking this may have been a problem from 2.0 beta and was eventually fixed.

As this appears to be fixed in recent versions, I'm marking this as resolved.

Changed in evergreen:
status: New → Fix Released
importance: Undecided → Low
Revision history for this message
Michael Peters (mrpeters) wrote :

Thanks to phasefx and dbs for pointing out that this is still unhandled when you say "No" to the override.

Perhaps missing ils_events.xml entries for "STAFF_C" and it's friends?

Changed in evergreen:
status: Fix Released → Confirmed
Revision history for this message
Michael Peters (mrpeters) wrote :
tags: added: pullrequest
Revision history for this message
Thomas Berezansky (tsbere) wrote :

Pushed to master, rel_2_1, and rel_2_0. Thanks!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.