Footer union link gets the PINES link forced after user login.

Bug #633363 reported by Anoop Atre
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Won't Fix
Low
Unassigned

Bug Description

Evergreen 1.6.0.6

Footer union link gets the PINES link forced after user login using the "default" skin.

This is because the "default" skin uses id "eg_gal_link" which forces the PINES link on login. It's a simple fix, change the id from "eg_gal_link" to "classic_link" which is used by the other footer links. Attached is a patch against trunk.

Revision history for this message
Anoop Atre (anoop-atre) wrote :
James Fournie (jfournie)
Changed in evergreen:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Dan Scott (denials) wrote :

To be honest, I don't understand why we would make this particular change in the default skin.

  * the link already has a class of "classic_link"; setting the id to "classic_link" seems strange
  * anyone running Evergreen in production will need to modify the skin, including the footer, and should blow this away if they're not in Georgia

However, I could see an argument for removing the link, and the corresponding buildEGGalLink() function in Open-ILS/web/opac/skin/default/js/sidebar.js, entirely, as it does add a small amount of attachEvt() overhead that should exist only in the PINES skin.

Chris, if you're reading this, would you be averse to pushing this functionality into the PINES-examples SVN repository?

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Should this one be won't fix?

Ben Shum (bshum)
Changed in evergreen:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.