Slony replication bug on holds shelf list

[James Fournie]

On the "holds shelf" display, when you cancel a hold, the hold remains in the list after the list refreshes. Refreshing the list a second time resolves the problem.

Delving into the code:

blahblah/xul/server/patron/holds.js:1042

1042 case 'shelf' :
1043 method = 'FM_AHR_ID_LIST_ONSHELF_RETRIEVE';
1044 params.push( obj.filter_lib || obj.data.list.au[0].ws_ou() );
1045 obj.controller.view.cmd_retrieve_patron.setAttribute('hidden','false');
1046 break;

This method should probably be authoritative in replicated setups, and I'm thinking it's probably OK in most cases for it to be authoritative. This call is to open-ils.circ.captured_holds.id_list.on_shelf.retrieve (Circ/Holds.pm:1083) which does not have an authoritative version.

[Mike Rylander (mrylander)]

Straight-forward upgrade to the API applied across master, 2.1 and 2.0. Thanks, James, for the detailed pointers into the code.