Staff client initial login screen
Bug #609326 reported by
Anoop Atre
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Dan Wells |
Bug Description
Evergreen: 1.6.0.6
OpenSRF: 1.2.2
PostgreSQL: 8.4
Server: Ubuntu Hardy
Desktop: Ubuntu Karmic
XULRunner: 1.9.2.7 - 20100716155810
Client Version: 1.6.0.6/1.6.0.4
Tabs in the staff client are missing the tab close icon with new xulrunner, only option is to use ctrl+w to close tab.
Changed in evergreen: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in evergreen: | |
status: | Confirmed → Fix Released |
To post a comment you must log in.
> Tabs in the staff client are missing the tab close icon with new
> xulrunner, only option is to use ctrl+w to close tab.
Or File->Close Tab from the top-level menu.
Yeah, I'm not sure what sort of debate has been happening in the
Mozilla community with this, but from what I understood a long time
ago, most of the functional enhancements for tabbox/tabbrowser were
Firefox specific, and did not make sense outside of that context. So
it's a probably a sort of throw the baby out with the bathwater
scenario, where xulrunner gets stocked with a minimal tab browser, and
Firefox does their own thing.
We can could take some of the code from the older xulrunner:
<hbox class=" tabs-closebutto n-box" align="center" pack="end"> "event. stopPropagation ();" tabs-closebutto n close-button" "disabled= disableclose, oncommand= onclosetab" www.mozilla. org/xbl" "g.menu. close_tab( )"/>
<toolbarbutton ondblclick=
class="
xbl:inherits=
xmlns:xbl="http://
oncommand=
</hbox>
But just shoving that in menu_frame_ overlay. xul:<tabs> </tabs> is kind
of brittle (especially if we try to put it next some of the anonymous
nodes that XBL uses to construct the element--such things are prone to
changing as we've seen), and we'd also need to disable it whenever we
were down to just one tab.
We could roll our own implementation of tabbox, but I don't think it's
worth it. May be better to wade into the Mozilla community and see
what's up.
-- Jason