Remove erroneous comment in Actor.pm

Bug #541608 reported by Steven Chan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

In Application/Actor.pm, the following lines of code

[6472] 2150 # run inside of a transaction to prevent replication delays
[14796] 2151 my $e = new_editor(authtoken=>$auth);

The comment on line 2150 is out of date and should be removed, because the new_editor function does not set xact flag as is normally done to start a database transaction.

Lines 2150 and 2151 was part of change set 6472, but line 2151 was then modified by change set 14796 (a materialized view was used instead and so a DB transaction was no longer needed). Change set 14796 should have removed the comment line as well.

James Fournie (jfournie)
Changed in evergreen:
importance: Undecided → Low
Revision history for this message
James Fournie (jfournie) wrote :

I don't see much point in patching this downstream from trunk, but here's a patch for trunk

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jason Stephenson (jstephenson) wrote :

The comment is still there though the patch may no longer apply. Does this really matter enough to fix?

Changed in evergreen:
status: Confirmed → Fix Released
status: Fix Released → Confirmed
Revision history for this message
Mike Rylander (mrylander) wrote :

Depends on if it's true or not ... [checks] ... well, the comment is, strictly speaking, correct, but the implementation is based on the (optional, for the client) authoritative-mode method that gets registered. I' removed it, because it made me have to go digging to check on it, and I suspect others would fall into that trap too. The situation, via api_name of the called method, is self-documenting.

--miker

Changed in evergreen:
status: Confirmed → Fix Committed
Dan Scott (denials)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.