Item detail summary screen doubling up on title

[Steve Callender]

In the staff client, when you select a title from the catalog and view the summary screen, if you were to "Go Back" and reselect the item, or search again and select the item a second time, the title appears to double up in the Title: field.

In rdetail_summary.xml I believe the problem is in the following,

                <td type='opac/slot-data' query='datafield[tag=245]' class='rdetail_item' id='rdetail_title'>
                    <script type='opac/slot-format'><![CDATA[
                        var out = '';
                        var list = dojo.query( 'subfield', item );
                        for (var i = 0; i < list.length; i++) {
                            out += dojox.data.dom.textContent(list[i]) + ' ';
                        }
                        return out;
                    ]]></script>

It looks like on a second viewing, the cache is retaining the rdetail_title and it's showing it immediately following the query of tag 245. I believe there should be a flag to check if using the Bib templates and if so to not display the rdetail_title but instead use just the query.

[Warren Layton (warren-layton)]

Our staff have stumbled into this as well. Perhaps the attached patch, which removes the population of rdetail_title from _rdetailDraw, offers a solution? For other fields that I have populated using BibTemplate, I have removed their respective statements from _rdetailDraw in rdetail.js...

P.S.: This looks like a duplicate of Bug #497488. I tried marking it as such in Launchpad, but it didn't recognize "497488" as a valid bug number for some reason.

[Dan Scott (denials)]

The approach we adopted for the Laurentian skin at http://svn.open-ils.org/trac/ILS-Contrib/browser/conifer/branches/rel_1_6_0/web/opac/skin/lul/xml/rdetail/rdetail_summary.xml is to make the rdetail_title element hidden:

<span class='hide_me' id='rdetail_title'></span>

and move the BibTemplate-based logic to a new element.

This maintains support for any skins that might want to continue to use the old format (for whatever reason - Opera support, maybe?). But it's a cruft-accumulating approach.

My temptation is to rewrite rdetail.js & rdetail_summary.xml so it doesn't use any of the old MVR-based approach and instead adopts a full BibTemplate-based solution.

[Mike Rylander (mrylander)]

Dan, please give into this temptation!

[Galen Charlton (gmc)]

Since Dan has not yet given into the temptation [what do you need? chocolate? :)], I've pushed a version of his Conifer template changes to trunk, rel_1_6, rel_1_6_0, and rel_1_6_1 to work around the immediate problem.

[Dan Scott (denials)]

Galen pushed this change in http://svn.open-ils.org/trac/ILS/changeset/17125/branches/rel_1_6_1 which was released in 1.6.1.2 and http://svn.open-ils.org/trac/ILS/changeset/17123/branches/rel_1_6_0 which was released in 1.6.0.8. Changing to "Fix released".