Colon in advanced search term causes empty result set

[Brandon Uhlman]

When an search term used in an advanced search includes a colon, the search always returns zero results - even if the basic search with the same term returns results.

I have confirmed that the problem is in (at least) Evergreen 1.4.0.7 (? - whatever GAPines is currently running) and 1.6.0.0 (BC Sitka), searching for the items 'me cheeta: my life', and 'lies: and the lying liars who tell them'. In both cases, basic search returns at least one result, and advanced search returns an empty result set.

Here's the logging for the OpenSRF call for the basic search.

2010-01-12 22:54:08 app2-2 open-ils.search: [INFO:19329:Biblio.pm:638:12633647022443261] compiled search is {"estimation_strategy":"inclusion","skip_check":0,"depth":0,"core_limit":10000,"searches":{"keyword":{"term":"lies: and the lying liars who tell them"}},"preferred_language":"en-CA","default_class":"keyword","org_unit":1,"limit":10,"visibility_limit":3000,"check_limit":"1000","offset":0}

And the advanced search:

2010-01-12 22:56:06 app1-2 open-ils.search: [INFO:27734:Biblio.pm:638:126336334713382162] compiled search is {"estimation_strategy":"inclusion","skip_check":0,"depth":0,"core_limit":10000,"searches":{"keyword":{"term":"keyword:lies: and the lying liars who tell them"}},"preferred_language":"en-CA","default_class":"","org_unit":1,"limit":10,"visibility_limit":3000,"check_limit":"1000","offset":0}

It appears the problem may be that whatever is generating the search call in advanced search is not separately quoting the term 'lies: and the lying lairs who tell them', while the basic search is. I tested with the term 'harry potter' in basic and advanced searches in 1.6.0.0, and the quoting difference is the same. The combination of incomplete quoting and blocking characters may be to blame, but this is as far as I can take this issue.

installation specs: Sitka (EG 1.6.0.0, OpenSRF 1.2.0, Postgres 8.3.x, Ubuntu Hardy); and Pines (don't know)

[Chris Sharp (chrissharp123)]

PINES is currently running EG 1.4.0.7, OpenSRF 1.0.7, Postgres 8.1.11, and Debian Etch, FYI

[Dan Scott (denials)]

http://svn.open-ils.org/trac/ILS/changeset/15369 and http://svn.open-ils.org/trac/ILS/changeset/15370, together, should fix this problem. I've tested the patches on our 1.6-ish system with success.

[Mike Rylander (mrylander)]

Backported to rel_1_6 and rel_1_6_0 for inclusion in 1.6.0.1