ALT text for format icons on search results page is always in English

Bug #491712 reported by Dan Scott
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.5
Fix Released
Medium
Unassigned

Bug Description

Evergreen trunk - search results page always displays ALT text in English for format icons; e.g. 'text' or 'moving image'

This text comes from the MARC2MODS* stylesheets, so it's going to take some cleverness to make it translatable.

James Fournie (jfournie)
Changed in evergreen:
status: New → Triaged
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I'm setting the importance to Undecided and leaving the status at Triaged because I don't know how seriously this needs to be fixed, nor if it also affects tpac.

If it does NOT affect tpac, then I'm inclined to say "Won't Fix."

Changed in evergreen:
importance: Medium → Undecided
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Needs confirmation that this affects TPAC.

Changed in evergreen:
status: Triaged → Incomplete
Revision history for this message
Pasi Kallinen (paxed) wrote :

It does affect TPAC, git HEAD as of Jan 11th

Revision history for this message
Pasi Kallinen (paxed) wrote :

Fix in http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/lp491712

I'm not quite happy with it - should perhaps do some caching so that it doesn't fetch the values for each result - but it works.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.5.0-alpha1
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-alpha2 → 2.5.0-beta1
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-beta1 → 2.5.0-rc
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.5.0-rc → 2.5.1
status: Incomplete → Triaged
Revision history for this message
Ben Shum (bshum) wrote :

Incomplete, needs rebasing to work with new catalog in 2.5+

Changed in evergreen:
milestone: 2.5.1 → 2.5.2
importance: Undecided → Medium
status: Triaged → Incomplete
Revision history for this message
Thomas Berezansky (tsbere) wrote :

I have come up with a branch that allows for use of the search label (so that the default search box entries are used for the icon labels as well) and enables translations to be pulled from the database, with cached retrievals so we only fetch each value once as we go through the results.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/translated_icon_labels

Changed in evergreen:
status: Incomplete → Confirmed
milestone: 2.5.2 → none
Revision history for this message
Ben Shum (bshum) wrote :

Tested tsbere's changes and they work for me.

Picked to master and rel_2_5. Thanks everyone!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.