Patron registration errors

[George Duimovich]

EG version: 1.6
OpenSRF version: 1.2
PG version: 8.2
Ubuntu: Ubuntu 8.04.3 LTS

When we switch to new patron skin from this value:

'XUL_PATRON_EDIT' : '/xul/rel_1_6_0_0/server/patron/ue.xhtml',

to this one:

'XUL_PATRON_EDIT' : '/eg/actor/user/register',

We notice a couple of problems:

1. Reset password button is missing

2. Manual reset of password does not appear to save. After saving updated password, you can confirm that it didn't save by getting "Login failed: User name or password not valid" when trying to log into the "My Account" page for first time. I can, however, log in with my previous password, despite "saving" new password.

[Jason Stephenson (jstephenson)]

Can someone please confirm this in 1.6.1.4?

[Ben Shum (bshum)]

In 1.6.1.4 and 2.0-rc1, confirmed that (1) reset password button is missing as reported. For (2) manual reset not saving, I am unable to duplicate this part of the bug, that seems to work correctly for me in all cases.

Given that this is related to the "new" patron editor, which is not enabled by default in 1.6.1.x, but is for 2.0, should this bug become a 2.0 wishlist or feature request to include a password reset button for 2.0+ to keep functionality similar to the original patron editor from earlier versions?

[Michael Peters (mrpeters)]

Confirmed in 2.0.4 as well. Manual reset works, however, there is no auto-generation of passwords as in previous versions and there is no button to auto-generate a reset password.

[Jason Stephenson (jstephenson)]

Here is a potential patch for this against trunk.

    Adds a "Generate Password" button to register.js when registering
    and editing a patron. The button is disabled if the org_unit is
    using phone numbers as passwords.

    The button calls ueMakeRandomPw(patron) to generate the password
    and sets both password fields to have the value of the new password.

For those who want to use git to pull my git branch:

To add my remote using id "jason" (only needs to be done once):

git remote add jason git://git.mvlcstaff.org/jason/ILS

If you don't use jason as the identifier here all of the below commands referring to jason will need to be adjusted.

Don't forget to fetch/update the remote:

git fetch jason
OR
git fetch --all

This branch will be jason/registerpatron

To check out the branch:

git checkout -b jason_registerpatron jason/registerpatron

To merge into your current branch (change branches first!):

git merge jason/registerpatron

To merge changes you made to your checked out version into the current branch (change branches first!):

git merge jason_registerpatron

[Jason Stephenson (jstephenson)]

Developer's Certificate of Origin attached.

[Michael Peters (mrpeters)]

Patch works like a charm. Using it in production on 2.0.4. Only caveat is that I changed the button to read "Reset Password" to match how it appeared in earlier versions.

[Dan Scott (denials)]

Applied to trunk, rel_2_1, and rel_2_0. Followed up with a separate patch to change the label to "Reset Password" and to take the button out of the tab focus path.

Many thanks, Jason!