Number validation in org unit settings creates problem with opac login

[James Fournie]

In the org unit settings, the validation on NumberTextBox causes large values to be formatted like "7,200". They are stored like this in the database. This was causing havoc with the opac timeout setting, making it impossible to login (a dialog would immediately popup saying you will be logged out). I have made a quick fix for this by using a ValidationTextBox with a regex instead.

[Dan Scott (denials)]

Hi James:

I tried this out (without your patch) on trunk, and it saved the value as "7200" in the database. I did see the form flip the value to 7,200 briefly after I hit "Okay" but the value itself was saved without being reformatted.

Maybe this is a problem in branches prior to trunk - possibly compounded by the version of Dojo in use. Can you include the version of Evergreen you're testing against & the version of Dojo in use?

[James Fournie (jfournie)]

Hi Dan,

We are running tag rel_1_6_0_0, rev 14750, dojo 1.3.2

I've tested this again and realized that the problem was with our legacy data. In 1.2 it was possible to enter 7,600 in the text box (with a comma, no quotes) which would be saved in the database as "7,600" (comma and quotes), and this would work fine. One of our sites did this.

Migrating this data to 1.6 makes this break, and it is no longer possible to login. So I guess at least this is something to report as an issue for sites upgrading from versions of Evergreen with the old org_unit_settings.xhtml to the Dojo version.

~James

[Jason Stephenson (jstephenson)]

This seems to actually be a problem in 1.2. Should this be changed to won't fix?

[Mike Rylander (mrylander)]

I think so... and, I think, therefore I do.