Blocked accounts can check out precats

Bug #2098898 reported by Terran McCanna
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.13
Fix Released
Medium
Unassigned
3.14
Fix Released
Medium
Unassigned

Bug Description

Starting new ticket based on comments from bug 954263 - first noticed in 3.6 and confirmed again in 3.13:

Pre-cat checkouts ignore blocks on patron accounts that a normal circulation would respect (when a patron has too many fines, for example)

Revision history for this message
Dan Briem (dbriem) wrote :

After submitting a precat dialog, there was no indication if there were blocking events and they were automatically overridden.

However, permissions seemed to be respected. For example, after submitting the precat dialog for a patron that exceeded the fine limit as a staff member without the PATRON_EXCEEDS_FINES.override permission, I got the perm block dialog.

Here's a branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp2098898_precats_auto_override_failure_events.

This removes the automatic override designation for precats. This way, if there are blocking events after the precat dialog is submitted, they are returned so the user is notified and can choose to override them or not.

If I misunderstood the bug and there are permission issues I didn't notice, I will remove the pullrequest tag.

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Revision history for this message
Susan Morrison (smorrison425) wrote :

Testing for Feedback Fest, confirmed that various blocks on a patron's account now prevent a precat checkout and require an override. Tested when account exceeds fines, exceeds checkouts, exceeds overdues, has a STAFF_CHR block, and is expired.

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thank you Dan and Susan!

Fix merged back to rel_3_13.

Changed in evergreen:
milestone: none → 3.15-rc
importance: Undecided → Medium
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.