Item details page - Remove from basket

[Terran McCanna]

Evergreen 3.14 -

On the item details page, the basket options on the right hand actions menu aren't working right.

If the item is not in a basket, the "Remove from basket" option is appearing instead of the "Add to basket option."

If the item IS in a basket, the "Remove from basket" option disappears.

[Jane Sandberg (sandbergja)]

Confirmed on today's main.

[Terran McCanna (tmccanna)]

In the process of fixing this, I also found that the View Basket hasn't been hiding/disappearing as intended either. The intention of the original code was to show the View Basket button when there is at least 1 item in the basket and hide it when there are no items in the basket yet. My proposed fix addresses that as well as the Add/Remove buttons.

(And thanks to Stephanie for pointing me to the JavaScript instead of trying to figure out how to do it in Perl!)

Proposed patch at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2093791_opac_basket_buttons

[Terran McCanna (tmccanna)]

(bumped to High since the regression broke patron functionality)

[Terran McCanna (tmccanna)]

Reviewed and signed off during Collaborative Code Review - Jane volunteered to push this commit later today.

[Jane Sandberg (sandbergja)]

Pushed to rel_3_14 and above. Thanks Terran and all reviewers!