Angular unit tests can't compile on main

Bug #2069098 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned

Bug Description

Expected behavior: when I run `npm run test` from the eg2 directory of a running evergreen system, all tests pass.

Actual behavior: `npm run test` currently returns a compilation error on today's main.

Impact: Developers, committers, and release teams can't use the unit tests as a safety net to check for regressions, since they can't even run.

Patch forthcoming, should be some quick fixes.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here is the branch: user/sandbergja/lp2069098-npm-run-test-failures

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2069098-npm-run-test-failures

To test, you can:
1. On an Evergreen server running today's main, install Firefox and Chromium
2. cd into the eg2 directory
3. Run `npm run test` -- notice it doesn't compile
4. Apply the commit
5. Run `npm run test` -- notice all 116 tests pass

For more info about running tests, see https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa

tags: added: angular pullrequest
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 3.14-beta
Revision history for this message
Terran McCanna (tmccanna) wrote :

Tested during a Monday code review session and signed off by me, Michele Morgan, Steven Mayo, and Scott Angel.

Fix merged to main and rel_3_13.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

I've removed the targeting to rel_3_13 - as noted in bug 2070411, this shouldn't have been backported to rel_3_13.

no longer affects: evergreen/3.13
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.