Quick Add Item function not working when creating a new MARC Record

[Rietveld]

This Bug is reported from version 3.12.1, and has been observed at the https://demo.evergreencatalog.com instance as well.

In the new Angular staff client, the Add Item function that sits on top of the MARC editor does not work anymore when one is creating a new MARC record.

While normally you would be sent to the Holdings Editor, like in the case if one tries the quick Add Item function within the MARC edit view of a record already exists, when it is used during the creation of a new record that fails.

In the browser console one is warned of errors of the offline-db-worker.js

> Lovefield worker received action=insertOrReplace schema=cache table=Setting field= value=
> shared worker replying with error
> > Object { code: 202, message: "http://google.github.io/lovefield/error_lookup/src/error_lookup.html?c=202&p0=Setting.value" } | offline-db-worker.js:341:17
> worker request failed with
> > undefined |main.bfb37b2ccfc3f56a.js:3:6158

[Michele Morgan (mmorgan)]

This reminded me of bug 1986706, which was fixed prior to 3.12. Comment #3 mentions a pop-up blocker preventing the holdings editor from opening.

In Chrome, when I enabled pop-ups for demo.evergreencatalog.com, the holdings editor opened for me following these steps:

-Select Cataloging -> Create New MARC Record
-Choose the k_book template and select Load
-Enter the MARC record data
-Check off the Add Item checkbox and enter call number and barcode information
-Click Save

The bib record is saved and the Holdings Editor opens in a new tab.

[Rietveld (rietveld)]

I just tried in Chromium, and indeed if one manually adds the domain to the list of sites allowed to open pop-ups, it does work.
It is just weird that it fails silently without warnings / without requesting to open pop-ups like sites normally do.

In Firefox, instead, it still keeps failing without any warning/notice, even when explicitly allowing pop-ups for the domain, and even when allowing pop-ups for all domains and turning off all privacy features.

[Kathy Lussier (klussier)]

Hi Rietveld,

Would it be okay if I marked this bug as a duplicate of https://bugs.launchpad.net/evergreen/+bug/1781003? It asks for a warning when popups are blocked. Feel free to click the "affects me too" link on it to add some heat to it.

[Rietveld (rietveld)]

Hello Kathy,

Thanks for pointing out the overlap!

I will add myself to the affected list! But still I would not say it is a duplicate, because even when allowing popups, the function doesn't work in Firefox ( the browser used at the library I work at ).

Especially as the function works when the record already exists, without needing to resort to Chrome, I suspect there is something else that could be fixed.