AngularJS forces Angular to forget too much (followup to bug 1996818)

[Mike Rylander]

Evergreen version 3.10+

Synchronizing the patron target for holds was improved over several bugs, but comment 5 on bug 1996818 notes a case where the Angular-initiate cookie is cleared, but too aggressively as it turns out.

When /any/ AngularJS interface is loaded, the cookie is cleared. That's a bit much because it's trivial to load the Item Status interface via the View link on the record page in place-hold-for-patron context. I can't see a reason to clear the cookie simply because an AngularJS interface was loaded /somewhere/ in the same browser, so a branch is forthcoming to not do that.

[Mike Rylander (mrylander)]

Branch available at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-2065913-donot_forget_me_so_quickly