Angular unit tests are failing on main

Bug #2065457 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

To recreate on a running Evergreen system, cd Open-ILS/src/eg2 && npm run test

The error I get:
Error: src/app/staff/cat/volcopy/copy-attrs.component.spec.ts:27:21 - error TS2554: Expected 9 arguments, but got 8.

27 component = new CopyAttrsComponent(idlMock, orgMock, authServiceMock,
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
28 formatServiceMock, storeServiceMock, fileExportServiceMock,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
29 toastServiceMock, volCopyServiceMock);
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  src/app/staff/cat/volcopy/copy-attrs.component.ts:108:9
    108 public volcopy: VolCopyService
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    An argument for 'volcopy' was not provided.

Not sure if that is the only error, or if there are others lying in wait once it can compile.

Tags: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :

This branch should do the trick: user/sandbergja/lp2065457-npm-run-test

And a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2065457-npm-run-test

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.13-beta
Revision history for this message
Blake GH (bmagic) wrote :

Thanks Jane! It fixed it. I signed off and pushed to main

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.