OPAC advanced search: selecting a shelving location group doesn't update the shelving locations

[Jane Sandberg]

Steps to recreate:

1. Load the enhanced concerto data set
2. Go to the OPAC advanced search screen
3. Open the shelving location area
4. Use the "Search library" dropdown to select a few libraries and systems. Note that the shelving location checkboxes update to match the org unit that you have selected.
5. Select the "Juvenile Collection" from the "Search library" dropdown. Note that nothing happens.
6. Open your browser's dev tools console. Note that we got an error message: "TypeError: org_unit is undefined"

I will be fixing this bug, as well as removing Dojo from copyloc.js, on behalf of NOBLE.

[Jane Sandberg (sandbergja)]

Here is a branch that allows the OPAC's shelving location selector to be limited to a shelving location group: user/sandbergja/lp2060351-opac-shelving-location-selector-groups

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2060351-opac-shelving-location-selector-groups

It also removes Dojo from copyloc.js and gets it under test.

To run the automated tests, run cd Open-ILS/web/opac/deps && npm run test

To test in a browser:

1. Apply the top two commits of this branch
2. Run make install
3. Load the enhanced concerto data set
4. Go to the OPAC advanced search screen
5. Open the shelving location area
6. Use the "Search library" dropdown to select a few libraries and systems. Note that the shelving location checkboxes update to match the org unit that you have selected.
7. Select the "Juvenile Collection" from the "Search library" dropdown. Note that the shelving location checkboxes update to match the locations included in the group.

This was commissioned by NOBLE, who will be testing it. I'll add the pullrequest tag after their testing and any follow-up work.

[Blake GH (bmagic)]

Jane,

Installing the patch removes "Shelving Location" from the available list of Green Filter Bars in the Advanced Search page.

[Jane Sandberg (sandbergja)]

Interesting, thanks, Blake! Would you mind sharing which browser you saw this in, and if there were any errors in the browser console?

[Kathy Lussier (klussier)]

Hi Blake!

We've been testing the patch here - https://newcat-next.noblenet.org/eg/opac/advanced - and have not seen that issue.

[Christine Morgan (cmorgan-z)]

Testing on https://newcat-next.noblenet.org/eg/opac/advanced I am finding that the shelving location is not being retained if you refine the search.

To recreate:

1. In Advanced Search enter your search terms. (I used harry potter)
2. Select a Search Library. (I chose Beverly Children's)
3. Open the Shelving Location section and select one. (I chose Children's DVD)
4. Click Submit.
5. From the search results page note that the Locations filter displays with your chosen shelving location.
6. Click Refine My Original Search.
7. On the Advanced Search page open the Shelving Location section again. Note that the location you previously selected is no longer selected.

[Jane Sandberg (sandbergja)]

Thanks so much for your testing, Christine, and for identifying this issue! I can confirm the issue, and also it looks like it affects the Bootstrap OPAC generally (I also noticed it on demo.evergreencatalog.com), see bug 1910563. In addition, my branch had an additional bug that got in the way of the checkboxes showing on "Refine My Original Search": it did not know how to get checkbox information from URLs that separate params by semicolons, which is how the OPAC likes to separate them.

I pushed a new commit to the same branch (user/sandbergja/lp2060351-opac-shelving-location-selector-groups) that addresses both issues, and gets "Refine My Original Search" working again for me. So now, you'll need the top 3 commits of that branch for testing.

[Michele Morgan (mmorgan)]

Thanks Jane! This looks great.

I'm adding NOBLE's signoff:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp2060351-opac-shelving-location-selector-groups_signoff

user/mmorgan/lp2060351-opac-shelving-location-selector-groups_signoff

[Jane Sandberg (sandbergja)]

Thanks, Michele, Christine, and the whole NOBLE crew. Adding the pullrequest tag to get more community eyes on this.

[Michele Morgan (mmorgan)]

Removing the signedoff tag as this should get wider community testing.