marc-export: hidden items can be exported as visible

[Jason Stephenson]

Evergreen version: all

When exporting items in marc_export, items that should be flagged hidden because of status or location are not flagged hidden. marc_export only takes into account the item's opac_visible field when adding the "hidden" value in 852 subfield x.

These items are appropriately skipped if the --exclude-hidden option is used. The above only happens when that option is absent from the command line.

[Jason Stephenson (jstephenson)]

Branch user/dyrcona/lp2056343 (https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp2056343).

From the commit message:

    To verify this bug, find some items that have a status or copy
    location that have opac_visible=false but the items, volumes, etc.,
    are opac_visible=true. See that the copies with the location or
    status with opac_visible=false do not have the subfield x with the
    value of "hidden."

    You can do the above on a system with Concerto data installed using
    the following command:

        echo 232 | marc_export --pipe --items -f xml > 232.xml

    The 852 fields with subfield c having the values of "Display" should
    have subfield x with the value of "hidden" but do not.

    After applying this patch and reinstalling marc_export, repeat the
    above steps and see that the 852 fields for the items that meet the
    criteria for status or location now have the subfield x with the value
    of "hidden."