deleted column on biblio.record_note not completely implemented

[Galen Charlton]

The changes in bug 1929242 included adding a 'deleted' flag to biblio.record_note.

However, nothing that can be done via the staff interface would cause that flag to ever be set to true. There is no rule or trigger to set that flag field rather than actually deleting a biblio.record_note row, nor does the UI include the deleted flag in the record note editor. Deleting a record note via the interface deletes the row.

Neither asset.copy_note nor asset.call_number_note have a deleted column.

Is it in fact desired to have the ability to retain deleted record notes and only logically delete them?

[Mike Rylander (mrylander)]

IMO, as long as there is a separate permission for deleting record notes, I think we can drop the deleted BOOL column. Local sites could add an auditor if they want to time travel.

If that's the consensus, we should probably remove that column ASAP to avoid report dependencies from creeping in.

[Tiffany Little (tslittle)]

I actually end up on the opposite side of the fence. :)

My thoughts, in no particular order:

- I don't quite understand why it would be on local sites to add a new auditor table, when the deleted field already exists in main and just needs to be hooked up via this bug

- End users don't have access to auditor tables through the reporter. They would have to submit a support request to get information about deleted record notes. Leaving it as a column on the table makes it reportable if necessary

- I may want to see previous notes on a record that are no longer immediately necessary, but may still have some use/knowledge in them

- There is an editor column (albeit not working quite right atm, see bug 1982892), and if a note is deleted then I would want to know who did it.

- It's easy to add an autofilter to Angular grids so non-deleted notes show first, but users still have easy access to them