Display Org Unit ID in Org Unit Configuration

Bug #2051879 reported by Terran McCanna
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned
3.11
Fix Released
Wishlist
Unassigned

Bug Description

I frequently need to know the numeric ID of a particular org unit and it's frustrating that it's not available in the Org Unit Configuration interface.

Branch coming shortly.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Initially I tried just displaying the id as a read-only field in the edit table which uses the aou class of the IDL - however, that class uses the shortname as the ID (at least, that's what it looks like to me), so it just displayed the shortname instead of the numeric id.

So, I added it after the shortname above the edit table instead. Not sure if there is a better way to do this - suggestions welcome.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp2051879_display_id_in_org_config

tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Galen Charlton (gmc) wrote :

I looked into why just displaying the id field in the form didn't work, and it turns out it's because the IDL is asserting that the type of actor.org_unit.id is itself "org_unit", i.e., a link to an org_unit. While it's been that way since 2009, I'm not sure that's correct. On the other hand, changing the datatype might have unforeseen consequences. Consequently, I've opened bug 2051944 for that issue.

Regardless, sticking the ID in the heading above the form works for me, so I've tested and signed off. Branch is user/gmcharlt/lp2051879_signoff

tags: added: signedoff
Changed in evergreen:
importance: Medium → Wishlist
Revision history for this message
Galen Charlton (gmc) wrote :

Also, while this is a wishlist (the Dojo OU administration page didn't display the ID either), I think this one is small enough to backport to maintenance branches.

Changed in evergreen:
milestone: none → 3.12.1
Revision history for this message
Galen Charlton (gmc) wrote :

Noting that if there's a strong preference to have the ID be displayed in the form (and that would be more consistent with other interfaces), using the customTemplate field option for the ID field would work.

Changed in evergreen:
milestone: 3.12.1 → 3.12.2
Revision history for this message
Galen Charlton (gmc) wrote :

Terran, now that I've tested and signed off on Mike's patch for bug 2051944, would you be willing to try going back to displaying the ID in the form itself?

tags: added: needsdiscussion
removed: signedoff
Changed in evergreen:
milestone: 3.12.2 → 3.12.3
tags: added: needswork
removed: needsdiscussion pullrequest
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

I don't understand how the patch for bug 2051944 has any impact on this bug. It looks like it's just adding some read-only safety?

Revision history for this message
Terran McCanna (tmccanna) wrote :

Never mind my last comment, I think I got it...

Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
removed: needswork
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Tested the latest patch and force-pushed a signoff to working/user/gmcharlt/lp2051879_signoff

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Pushed to rel_3_11 and above. Thanks, Terran and Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.