Parts hold check does not ignore deleted parts

[Britta Dorsey]

v3.11.2
Chrome v120.0.099.217

Global setting "Holds: Require Monographic Part When Present for hold check" ignores deleted parts on a bibliographic record.

A hold was attempted on a record that did not have any parts and the Part area of the hold function said "N/A". When Place Hold was clicked, the error TITLE_HOLD_WHEN_MONOGRAPHIC_PART_REQUESTED appeared.

We double checked and saw that the record in question still had deleted parts associated with it which led us to believe that the global setting is not ignoring deleted parts.

I can confirm that this does not seem to happen when the library setting "Require Monographic Part when Present" is set to True.

[Galen Charlton (gmc)]

Confirmed. The query for monograph parts in _check_title_hold_is_possible() in Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm looks like it should be updated to filter out deleted parts.

A similar in query all_rec_holds() might need a closer look. It checks for all parts on the title, including deleted ones, but since the routine is for getting all (active) holds on a bib record, we may actually want part holds where the part somehow got deleted without updating the hold. However, this routine may be better off being the topic of a separate bug.

(I've made significant edits to this comment)

[Galen Charlton (gmc)]

A patch is available in working/user/gmcharlt/lp2051557_ignore_deleted_parts_for_title_holds / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2051557_ignore_deleted_parts_for_title_holds

[Galen Charlton (gmc)]

(I've opened bug 2051562 regarding the parts query in all_rec_holds())

[Ruth Frasur Davis (redavis)]

We have tested this patch and verified that the fix works. I consent to signing off on this using my name, redavis/rfrasur and email address, <email address hidden>.

[Galen Charlton (gmc)]

Thanks. When constructing the signoff line when the patch is merged, should your name be listed as "Ruth Davis"?

[Jason Etheridge (phasefx)]

I've committed this to master and rel_3_11, and I went with a sign-off for Ruth that was used last month.

Thanks!

[Jason Etheridge (phasefx)]

And rel_3_12, but I'll let someone else manage the Launchpad-fu for that one.

[Ruth Frasur Davis (redavis)]

++ and Ruth Davis or Ruth Frasur Davis. Or whatevs. "Ruth to the T"

[Jason Etheridge (phasefx)]

And I meant to say main; old habits. :-)