make_release should have better defaults

Bug #2051370 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.11
Fix Released
Medium
Unassigned

Bug Description

The make_release script is used as part of the release process (see https://wiki.evergreen-ils.org/doku.php?id=dev:release_process:evergreen:how_to_build#run_the_release_builder_script).

By default, make_release builds the XUL client, and does not build the Angular and AngularJS clients. Both defaults are the opposite of what we'd want for a modern Evergreen release.

Switching the defaults would make the release process ever so slightly simpler, and reduce the potential for mistakes in the process.

Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

The branch user/gmcharlt/lp2051370_change_make_release_defaults / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2051370_change_make_release_defaults has a two-patch series to remove make_release's ability to build the XUL client and to default it to building the browser client.

tags: added: pullrequest
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote (last edit ):

Thanks, Galen! I tested this as recommended in the commit messages. It worked except that the first commit removed a `cd`, and then subsequent steps started taking place in the wrong directory and failing. I pushed a follow up to that.

I pushed to rel_3_11 and above. I also updated the release documentation in the wiki accordingly: https://wiki.evergreen-ils.org/doku.php?id=dev:release_process:evergreen:how_to_build#run_the_release_builder_script

Changed in evergreen:
milestone: none → 3.12.1
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.