Line Items Search not retrieving data on first try

[Garry Collum]

Evergreen 3.11.2
Chrome
Windows 10 & 11

We just upgraded to 3.11.2 from 3.11.1. This was not an issue in 3.11.1. It's also not an issue on a MacBook Pro.

Go to Acquisitions - General Search
As a search filter select Line Item Attribute UPC and scan or type in a UPC code.

No results are retrieved and the search filter and search button block is collapse so it is not visible.

Select the drop-down arrow for the search box, (it's to the right of "Search for records matchin 'all' of the following terms), and click on search. The results are retrieved.

[Garry Collum (gcollum)]

Just an addendum. This occurs with a carriage return, or a scan with an added carriage return. The carriage return seems to be focused on the collapse button. If you click on search, the search takes place.

[Galen Charlton (gmc)]

I've traced this:

- the patch for bug 1615714, among other things, converted some links and divs to buttons
- however, the button type was not always specified, including on the acq search form expand/collapse controls, meaning that it defaulted to "submit".
- a carriage return tries a form submission, and looks for the first button that is of type submit - and toggles the expander rather than submitting the search

As far as I can tell, this issue applies _only_ to 3.11.2. In main and rel_3_12, a patch to fix lint errors (bug 1850473) fixed the buttons without assigned types, but wasn't backported to rel_3_11.

The fix for the acquisitions search form is straightforward, although it looks like various other pages should be looked at.

[Galen Charlton (gmc)]

And to clarify one point, a _lot_ of Angular buttons in rel_3_11 didn't have their types specified. The patch bug 1615714 is not responsible for them all, it just happened to hit a form where enter-to-submit is commonly done.

[Galen Charlton (gmc)]

A patch is available in user/gmcharlt/lp2049780_fix_enter_to_submit_acq_search / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp2049780_fix_enter_to_submit_acq_search

Note that this is needed only for rel_3_11

[Galen Charlton (gmc)]

See also bug 2051170 for the general problem with unspecified button types.

[Garry Collum (gcollum)]

Test on rel_3_11 and it works perfectly.

I have tested this code and consent to signing off on it with my name, Garry Collum and my email address, <email address hidden>

[Galen Charlton (gmc)]

Thanks for testing, Garry!

Given the impact this is having and the straightforward nature of the patch, I've gone ahead and merged this to rel_3_11.